Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

fix web.mit.edu and related domains. They don't support HTTPS for the public - #16129

Closed
varenc wants to merge 1 commit into
EFForg:masterfrom
varenc:fix-mit-base-domains
Closed

varenc wants to merge 1 commit into
EFForg:masterfrom
varenc:fix-mit-base-domains

Conversation

@varenc

@varenc varenc commented Aug 4, 2018

Copy link
Copy Markdown

web.mit.edu (and its identical www.mit.edu and mit.edu versions) only support HTTPS if the browser has an MIT issued certificate. This means HTTPS works fine if an MIT student/prof/affiliate is doing the testing but it does not work for the general public. They get this error:
image

The problem was introduced 6 months ago but only effects a narrow use case. The rule I’m deleting causes problems for non-MIT affiliates if they visit the domain roots “http://web.mit.edu“ or “http://mit.edu” or “http://www.mit.edu” directly, but not if they visit anything with a path like http://web.mit.edu/~jhawk (except for things under /files/).

This obscured the issue somewhat and perhaps took awhile for it to be noticed.

That said, right now MIT’s base domains don’t support HTTPS for the public and HTTPS redirects for these shouldn’t be built into HTTPS Everywhere.

Cheers

@Hainish Hainish added the top-1k label Aug 4, 2018
@Bisaloo

Bisaloo commented Aug 4, 2018

Copy link
Copy Markdown
Collaborator

Hi @varenc, thank you for your pull request. This looks good!

Can you have a look at travis' output and remove broken targets / rules please?

@Bisaloo Bisaloo self-assigned this Aug 4, 2018
@varenc

varenc commented Aug 8, 2018

Copy link
Copy Markdown
Author

update! MIT claims they're fixing this issue with anonymous HTTPS users on Friday this week: http://kb.mit.edu/confluence/pages/viewpage.action?pageId=152593506

I'll test after that goes out and if they fixed it, as they should, I'll happily close this PR.

@Bisaloo

Bisaloo commented Aug 12, 2018

Copy link
Copy Markdown
Collaborator

This looks fine now as far as I can tell 👍

@varenc

varenc commented Aug 13, 2018

Copy link
Copy Markdown
Author

so MIT just rolled out HTTPS support and it's somewhat working. The domain root website works well, but there's a very long tail of other mit.edu hosted sites with mixed-content that end up breaking over HTTPS. https://web.mit.edu/puzzle/www/ vs http://web.mit.edu/puzzle/www/ for example relies on CSS requested over HTTP.

Given this, I'm inclined to abandon this diff. MIT-complex.xml converts only the root urls and /files/* urls to HTTPS but leaves everything else untouched. Those places do work fine over HTTPS so this isn't breaking anyone anymore. But I don't think these rules should be expanded to apply to all web.mit.edu URLs for the reasons cited above. This makes sense since the rule was probably originally written by an MIT affiliate that had HTTPS access before it was open to the public.

Will close this PR soon unless anyone thinks otherwise!

@Bisaloo

Bisaloo commented Aug 14, 2018

Copy link
Copy Markdown
Collaborator

That makes sense to me. I'm okay with closing this PR.

@varenc

varenc commented Aug 14, 2018 •

Copy link
Copy Markdown
Author

closing this for now!

in 6-12 months we should check in again and see if more sites hosted on web.mit.edu work under HTTPS...but I doubt it. (It's a bit a chicken and egg problem. If HTTPS Everywhere enforced HTTPS on those sites they'd be motivated to switch more quickly! or if MIT just goes full HSTS... )

(hmmm maybe MIT could just set up some sort of page rewriting middleware that at least fixes the more obvious mixed content warnings)

@varenc varenc closed this Aug 14, 2018
@Bisaloo Bisaloo removed their assignment Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants